feat: edit application position fields #5729
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrissDrawing
added
the
1 review needed
✅ Deploy Preview for bloom-flagly canceled.
|
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
...ners/src/components/applications/PaperApplicationDetails/sections/DetailsApplicationData.tsx
Show resolved
Hide resolved
...ners/src/components/applications/PaperApplicationDetails/sections/DetailsApplicationData.tsx
Show resolved
Hide resolved
| --field-value-help-text-color: var(--seeds-input-text-label-color); | ||
| } | ||
|
|
||
| .field-value-field-style { |
Collaborator
There was a problem hiding this comment.
question: Can you walk me through why we needed these styles? Ideally we never need overrides 🤞 Would also love the padding the match the detail FieldValue so that it's flush to the left
Collaborator
There was a problem hiding this comment.
If we do need these overrides, we can make a scss module file FormApplicationData.module.scss that lives right next to the component file and put the styles in there
Collaborator
Author
There was a problem hiding this comment.
It's not that we need that it's just it looks awkward without it, especially when you switch between waitlist and non waitlist status and it jumps significantly.
Not sure if it is ok to modify it to this point, but at least font-family and padding-top on label seem to be reasonable alignment. But i can live without it (i hope :))
Unless we maybe just want to use `disabled` prop on `Field` 🤔
emilyjablonski
requested changes
Jan 6, 2026
Collaborator
emilyjablonski
left a comment
emilyjablonski
left a comment
There was a problem hiding this comment.
This is looking great!! Just have a few more trivial comments
emilyjablonski
added
needs changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #5528
Description
Adds additional fields for application status.
How Can This Be Tested/Reviewed?
On partners go to applications page for listing with
enableApplicationStatusflag, add/edit application it should have additional fields forApplication data(wait listandwait list - declinedstatus).When you add those, they should switch to non editable fields for different statuses than above.
also check if lottery field is present if reviewOrder is lottery, and not visible if it's not.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: