-
Notifications
You must be signed in to change notification settings - Fork 40
feat: edit application position fields #5729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for bloom-flagly canceled.
|
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
...ners/src/components/applications/PaperApplicationDetails/sections/DetailsApplicationData.tsx
Outdated
Show resolved
Hide resolved
...ners/src/components/applications/PaperApplicationDetails/sections/DetailsApplicationData.tsx
Show resolved
Hide resolved
emilyjablonski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great!! Just have a few more trivial comments
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-flagly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
...ners/src/components/applications/PaperApplicationDetails/sections/DetailsApplicationData.tsx
Outdated
Show resolved
Hide resolved
emilyjablonski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, just going to approve and when that's made feel free to merge!
This PR addresses #5528
Description
Adds additional fields for application status.
How Can This Be Tested/Reviewed?
On partners go to applications page for listing with
enableApplicationStatusflag, add/edit application it should have additional fields forApplication data(wait listandwait list - declinedstatus).When you add those, they should switch to non editable fields for different statuses than above.
also check if lottery field is present if reviewOrder is lottery, and not visible if it's not.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: